ARROW-17418: [Doc][Java] Dataset library able to compile with mvn command#13889
Conversation
| <configuration> | ||
| <executable>cmake</executable> | ||
| <commandlineArgs> | ||
| -DARROW_BOOST_USE_SHARED=OFF |
There was a problem hiding this comment.
We can use ARROW_DEPENDENCY_USE_SHARED=OFF instead of multiple ARROW_*_USE_SHARED=OFFs.
| -DCMAKE_INSTALL_LIBDIR=lib | ||
| -DCMAKE_INSTALL_PREFIX=../java-dist | ||
| -DCMAKE_UNITY_BUILD=ON | ||
| -Dre2_SOURCE=BUNDLED |
There was a problem hiding this comment.
We can use ARROW_DEPENDENCY_SOURCE=BUNDLED instead of multiple *_SOURCE=BUNDLEDs.
| -DARROW_ORC=${ARROW_ORC} | ||
| -DCMAKE_BUILD_TYPE=Release | ||
| -DCMAKE_INSTALL_LIBDIR=lib | ||
| -DCMAKE_INSTALL_PREFIX=../java-dist |
There was a problem hiding this comment.
Can we use the arrow.c.jni.dist.dir property instead of ../java-dist?
| <configuration> | ||
| <executable>cmake</executable> | ||
| <commandlineArgs> | ||
| --build . --target install |
|
LGTM. Is there any reason this can't be merged? |
| -DCMAKE_INSTALL_LIBDIR=lib | ||
| -DCMAKE_INSTALL_PREFIX=${arrow.cpp.build.dir} | ||
| -DCMAKE_UNITY_BUILD=ON | ||
| -DARROW_DEPENDENCY_SOURCE=BUNDLED |
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
There was a problem hiding this comment.
It seems that it's not done. Could you check again? Or should I push a commit for it?
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
We can merge this after we sort lists.
| -DARROW_DEPENDENCY_USE_SHARED=OFF | ||
| -DARROW_CSV=ON | ||
| -DARROW_DATASET=ON | ||
| -DARROW_FILESYSTEM=ON | ||
| -DARROW_GANDIVA=ON | ||
| -DARROW_GANDIVA_JAVA=ON | ||
| -DARROW_GANDIVA_STATIC_LIBSTDCPP=ON | ||
| -DARROW_JNI=ON | ||
| -DARROW_ORC=ON | ||
| -DARROW_PARQUET=ON | ||
| -DARROW_PLASMA=ON | ||
| -DARROW_PLASMA_JAVA_CLIENT=ON | ||
| -DARROW_S3=ON | ||
| -DARROW_USE_CCACHE=ON | ||
| -DCMAKE_BUILD_TYPE=Release | ||
| -DCMAKE_INSTALL_LIBDIR=lib | ||
| -DCMAKE_INSTALL_PREFIX=java-dist | ||
| -DCMAKE_UNITY_BUILD=ON | ||
| -DARROW_DEPENDENCY_SOURCE=BUNDLED |
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
| -DCMAKE_BUILD_TYPE=Release | ||
| -DCMAKE_INSTALL_PREFIX=${arrow.c.jni.dist.dir} | ||
| -DCMAKE_PREFIX_PATH=${project.basedir}/../java-dist | ||
| -DARROW_JAVA_JNI_ENABLE_DEFAULT=OFF | ||
| -DARROW_JAVA_JNI_ENABLE_DATASET=ON | ||
| -DBUILD_TESTING=OFF |
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
| -DCMAKE_INSTALL_LIBDIR=lib | ||
| -DCMAKE_INSTALL_PREFIX=${arrow.cpp.build.dir} | ||
| -DCMAKE_UNITY_BUILD=ON | ||
| -DARROW_DEPENDENCY_SOURCE=BUNDLED |
There was a problem hiding this comment.
It seems that it's not done. Could you check again? Or should I push a commit for it?
|
Could you rebase on the master? |
Rebase + Update documentation to use new maven profiles, please your review, thanks |
|
Benchmark runs are scheduled for baseline = f57e1ba and contender = f4e79b1. f4e79b1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…mand (apache#13889) Dataset/ORC/Gandiva library (.so / .dylib) able to compile with mvn command $ mvn clean generate-resources -Pgenerate-jnicpp-dylib_so -DARROW_DATASET=ON -DARROW_ORC=ON -DARROW_GANDIVA=ON -N Authored-by: david dali susanibar arce <davi.sarces@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…mand (apache#13889) Dataset/ORC/Gandiva library (.so / .dylib) able to compile with mvn command $ mvn clean generate-resources -Pgenerate-jnicpp-dylib_so -DARROW_DATASET=ON -DARROW_ORC=ON -DARROW_GANDIVA=ON -N Authored-by: david dali susanibar arce <davi.sarces@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
4 participants
Dataset/ORC/Gandiva library (.so / .dylib) able to compile with mvn command
$ mvn clean generate-resources -Pgenerate-jnicpp-dylib_so -DARROW_DATASET=ON -DARROW_ORC=ON -DARROW_GANDIVA=ON -N